Skip to content

Adding an approval gate to the build job#273

Merged
Benjin merged 2 commits into
masterfrom
dev/benjin/addingEarlierCheck
May 15, 2026
Merged

Adding an approval gate to the build job#273
Benjin merged 2 commits into
masterfrom
dev/benjin/addingEarlierCheck

Conversation

@Benjin
Copy link
Copy Markdown
Member

@Benjin Benjin commented Feb 27, 2026

Description

Adding an approval gate before the build job runs

Code Changes

  • Unit tests are added, if possible
  • New or changed code follows the C# style guidelines defined in .editorconfig
  • All changes MUST be backwards compatible and changes to the shared az_func.GlobalState table must be compatible with all prior versions of the extension
  • Use core.debug or directly log to console to display relevant information
  • Use async and await for all long-running operations

Dependencies

  • If updating dependencies, run npm install to update the lock files and ensure that there are NO major versions updates or additional vulnerabilities in package-lock.json. If there are, contact the dev team for instructions.

Documentation

dzsquared
dzsquared previously approved these changes Feb 27, 2026
llali
llali previously approved these changes May 15, 2026
@Benjin Benjin dismissed stale reviews from llali and dzsquared via 8fe908b May 15, 2026 16:40
@Benjin Benjin temporarily deployed to Automation test May 15, 2026 16:40 — with GitHub Actions Inactive
@Benjin Benjin temporarily deployed to Automation test May 15, 2026 16:40 — with GitHub Actions Inactive
@Benjin Benjin temporarily deployed to Automation test May 15, 2026 16:43 — with GitHub Actions Inactive
@Benjin Benjin temporarily deployed to Automation test May 15, 2026 16:43 — with GitHub Actions Inactive
@Benjin Benjin temporarily deployed to Automation test May 15, 2026 16:47 — with GitHub Actions Inactive
@Benjin Benjin had a problem deploying to Automation test May 15, 2026 16:47 — with GitHub Actions Failure
@Benjin Benjin deployed to Automation test May 15, 2026 16:55 — with GitHub Actions Active
@Benjin Benjin merged commit fd89aeb into master May 15, 2026
18 of 19 checks passed
@Benjin Benjin deleted the dev/benjin/addingEarlierCheck branch May 15, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants